Re: Use singular number when appropriate

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: David Fetter <david(at)fetter(dot)org>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use singular number when appropriate
Date: 2021-06-15 05:16:41
Message-ID: ea5e6698-9fd1-dc15-e8e7-671fc5cfea35@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15/06/2021 07:59, David Fetter wrote:
> Hi,
>
> I thought about using the dual, but wasn't sure how many languages
> support it.
>
> if (fail_count == 0 && fail_ignore_count == 0)
> snprintf(buf, sizeof(buf),
> _(" %s %d test%s passed. "),
> success_count == 1 ? "The" : "All",
> success_count,
> success_count == 1 ? "" : "s");

Constructing sentences like that is bad practice for translations. See
https://www.gnu.org/software/gettext/manual/html_node/Plural-forms.html.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-06-15 05:17:14 Re: Error on pgbench logs
Previous Message Heikki Linnakangas 2021-06-15 05:08:54 Re: Different compression methods for FPI