Re: [PATCH] support tab-completion for single quote input with equal sign

From: Jacob Champion <pchampion(at)vmware(dot)com>
To: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] support tab-completion for single quote input with equal sign
Date: 2021-09-03 23:54:01
Message-ID: ea03e654f995da19865806824d5f91627a4884b9.camel@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tang,

On Fri, 2021-09-03 at 04:32 +0000, tanghy(dot)fnst(at)fujitsu(dot)com wrote:
> I'd appreciate it if you can share your test results with me.

Sure! Here's my output (after a `make clean && make`):

cd . && TESTDIR='/home/pchampion/workspace/postgres/src/bin/psql' PATH="/home/pchampion/workspace/postgres/tmp_install/usr/local/pgsql-master/bin:$PATH" LD_LIBRARY_PATH="/home/pchampion/workspace/postgres/tmp_install/usr/local/pgsql-master/lib" PGPORT='65432' PG_REGRESS='/home/pchampion/workspace/postgres/src/bin/psql/../../../src/test/regress/pg_regress' /usr/bin/prove -I ../../../src/test/perl/ -I . t/*.pl
t/010_tab_completion.pl .. 17/?
# Failed test 'tab-completion after single quoted text input with equal sign'
# at t/010_tab_completion.pl line 198.
# Actual output was "CREATE SUBSCRIPTION my_sub CONNECTION 'host=localhost port=5432 dbname=postgres' \a"
# Did not match "(?^:PUBLICATION)"
# Looks like you failed 1 test of 23.
t/010_tab_completion.pl .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/23 subtests
t/020_cancel.pl .......... ok

Test Summary Report
-------------------
t/010_tab_completion.pl (Wstat: 256 Tests: 23 Failed: 1)
Failed test: 17
Non-zero exit status: 1
Files=2, Tests=25, 8 wallclock secs ( 0.02 usr 0.01 sys + 1.48 cusr 0.37 csys = 1.88 CPU)
Result: FAIL
make: *** [Makefile:87: check] Error 1

Thanks,
--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-09-04 00:01:50 Re: prevent immature WAL streaming
Previous Message Jacob Champion 2021-09-03 23:21:59 Re: [PATCH] test/ssl: rework the sslfiles Makefile target