Re: Recovering from detoast-related catcache invalidations

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Xiaoran Wang <fanfuxiaoran(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Recovering from detoast-related catcache invalidations
Date: 2024-12-25 09:27:38
Message-ID: ea00edec-d649-42bf-8cfb-13bc83d4af8e@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24/12/2024 09:38, Michael Paquier wrote:
> On Tue, Dec 24, 2024 at 12:18:09AM +0200, Heikki Linnakangas wrote:
>> My first attempt was to insert the CatCTup or CatCList entry to the catcache
>> before starting to build it, marked with a flag to indicate that the entry
>> isn't fully built yet. But when I started to write that it got pretty
>> invasive, and it felt easier to add another structure to hold the
>> in-progress entries instead.
>>
>> From ec248c69cb42a0747ecc6a63ac4e4682cce2ee93 Mon Sep 17 00:00:00 2001
>> From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
>> Date: Fri, 20 Dec 2024 18:37:44 +0200
>> Subject: [PATCH 1/1] Don't allow GetTransactionSnapshot() in logical decoding
>
> It seems to me that this is not what you intended to attach for the
> catcache inconsistency fix?

Right, sorry, here are the correct patches.

--
Heikki Linnakangas
Neon (https://neon.tech)

Attachment Content-Type Size
v2-0001-Demonstrate-catcache-list-invalidation-bug.patch text/x-patch 5.0 KB
v2-0002-Fix-bug-in-catcache-invalidation.patch text/x-patch 11.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-12-25 09:28:52 Re: Pass ParseState as down to utility functions.
Previous Message Hayato Kuroda (Fujitsu) 2024-12-25 08:25:20 RE: Logical replication timeout