| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump: Simplify internal archive version handling |
| Date: | 2016-10-25 21:03:58 |
| Message-ID: | e9a16c32-2908-5db9-7ccf-269b1e51400f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/13/16 9:13 AM, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> I propose the attached patch to clean up some redundancy and confusion
>> in pg_dump.
>
> Looks sane, though I'd suggest coding the access macros with shifts
> not multiplies/divides.
Done.
> Since these numbers are purely internal and not stored in this form in the
> file, I wonder whether we shouldn't drop the rightmost zero byte, ie make
> it just <maj><min><rev> not <maj><min><rev>00. That would save at least
> one divide/shift when accessing.
Done and committed. Thanks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-10-25 21:06:59 | Re: Wraparound warning |
| Previous Message | Merlin Moncure | 2016-10-25 20:08:39 | Re: emergency outage requiring database restart |