| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Failures in constraints regression test, "read only 0 of 8192 bytes" |
| Date: | 2024-03-11 07:09:39 |
| Message-ID: | e9847a44-8f69-483f-92dc-5a2ca0a8be59@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/03/2024 22:59, Thomas Munro wrote:
> On Mon, Mar 11, 2024 at 9:30 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> Barring objections, I'll commit the attached.
>
> +1
Pushed, thanks!
> I guess the comment for smgrreleaseall() could also be updated. It
> mentions only PROCSIGNAL_BARRIER_SMGRRELEASE, but I think sinval
> overflow (InvalidateSystemCaches()) should also be mentioned?
I removed that comment; people can grep to find the callers.
>> Hmm, I'm not sure if we need even smgrreleaseall() here anymore. It's
>> not required for correctness AFAICS. We don't do it in single-rel
>> invalidation in RelationCacheInvalidateEntry() either.
>
> I think we do, because we have missed sinval messages. It's unlikely
> but a relfilenode might have been recycled, and we might have file
> descriptors that point to the unlinked files. That is, there are new
> files with the same names and we need to open those ones.
Gotcha.
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-03-11 07:15:40 | Re: Spurious pgstat_drop_replslot() call |
| Previous Message | Mats Kindahl | 2024-03-11 06:59:48 | Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery |