| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: New "-b slim" option in 2019b zic: should we turn that on? |
| Date: | 2019-10-05 21:43:49 |
| Message-ID: | e93f047e-6c31-7a1e-b723-4418d756d9b1@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/17/19 6:42 PM, Tom Lane wrote:
>
> Despite the marginal payoff, I'm strongly tempted to enable this
> switch. The only reason I can think of not to do it is if somebody
> is using a Postgres installation's share/timezone tree as tzdata
> for some other program with not-up-to-date timezone library code.
> But who would that be?
>
> A possible compromise is to turn it on only in HEAD, though I'd
> rather keep all the branches working the same as far as the
> timezone code goes.
>
I've just run into an issue with this (commit a1207910968). The makefile
now assumes that zic has this switch. But I was attempting to get around
an issue on msys2 by using its zic, (ZIC=/usr/bin/zic configure ...). It
crashes on the floor because it doesn't know about "-b slim". I think we
probably need a way to turn this off.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-10-05 22:33:13 | Re: New "-b slim" option in 2019b zic: should we turn that on? |
| Previous Message | Nikolay Shaplov | 2019-10-05 21:23:00 | [PATCH] Add some useful asserts into View Options macroses |