| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: bug with expression index on partition |
| Date: | 2018-06-21 07:19:01 |
| Message-ID: | e935ba9c-c0a8-739e-c783-aae70c6ae6be@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/06/21 15:35, Amit Langote wrote:
> So, CompareIndexInfo and generateClonedIndexStmt are both doing the right
> thing, but DefineIndex is not. Attached is a patch to fix DefineIndex so
> that it converts indexParams before recursing to create the index on a
> partition.
I noticed that while CompareIndexInfo and generateClonedIndexStmt would
reject the case where index expressions contain a whole-row Var, my patch
didn't teach to do the same to DefineIndex, causing asymmetric behavior.
So, whereas ATTACH PARTITION would error out when trying to clone a
parent's index that contains a whole-row Var, recursively creating an
index on partition won't.
I updated the patch so that even DefineIndex will check if any whole-row
Vars were encountered during conversion and error out if so.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Convert-indexParams-to-partition-s-attnos-before-.patch | text/plain | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-06-21 07:24:19 | Buildfarm failure in rolenames.sql |
| Previous Message | Konstantin Knizhnik | 2018-06-21 07:12:17 | Re: libpq compression |