| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: More new SQL/JSON item methods |
| Date: | 2024-01-03 12:01:23 |
| Message-ID: | e913dde5-0209-441c-8040-dd2ace6415e0@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07.12.23 14:24, Jeevan Chalke wrote:
> We have the same issue with integer conversion and need a fix.
>
> Unfortunately, I was using int8in() for the conversion of numeric
> values. We should be using numeric_int8() instead. However, there is no
> opt_error version of the same.
>
> So, I have introduced a numeric_int8_opt_error() version just like we
> have one for int4, i.e. numeric_int4_opt_error(), to suppress the error.
> These changes are in the 0001 patch. (All other patch numbers are now
> increased by 1)
>
> I have used this new function to fix this reported issue and used
> numeric_int4_opt_error() for integer conversion.
I have committed the 0001 and 0002 patches for now.
The remaining patches look reasonable to me, but I haven't reviewed them
in detail.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey M. Borodin | 2024-01-03 12:04:41 | Re: Transaction timeout |
| Previous Message | Andrew Dunstan | 2024-01-03 11:57:57 | Re: WIP Incremental JSON Parser |