| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: base backup client as auxiliary backend process |
| Date: | 2020-02-17 17:42:52 |
| Message-ID: | e8f86ba5-48f1-a80a-7f1d-b76bcb9c5c47@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-02-03 13:47, Andres Freund wrote:
> Comment:
>
> - It'd be good to split out the feature independent refactorings, like
> the introduction of InitControlFile(), into their own commit. Right
> now it's hard to separate out what should just should be moved code,
> and what should be behavioural changes. Especially when there's stuff
> like just reindenting comments as part of the patch.
Agreed. Here are three refactoring patches extracted that seem useful
on their own.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pg_resetwal-Rename-function-to-avoid-potential-confl.patch | text/plain | 1.4 KB |
| 0002-Reformat-code-comment.patch | text/plain | 1.9 KB |
| 0003-Factor-out-InitControlFile-from-BootStrapXLOG.patch | text/plain | 5.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haumacher, Bernhard | 2020-02-17 18:01:38 | Re: Error on failed COMMIT |
| Previous Message | Juan José Santamaría Flecha | 2020-02-17 17:24:30 | Re: Fix compiler warnings on 64-bit Windows |