Re: [HACKERS] Crash on promotion when recovery.conf is renamed

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Magnus Hagander <magnus(at)hagander(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Crash on promotion when recovery.conf is renamed
Date: 2018-07-06 12:05:50
Message-ID: e8e8a5e4-560c-f241-7e1d-87547bc8c029@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 07/06/2018 07:18 AM, Michael Paquier wrote:
> Robert Haas wrote:
>> Although the state is now back to "Needs Review", I echo those
>> sentiments. This issue has now been hanging around for about 18
>> months.

No, those are my words, not Robert's :-)

> For what it's worth, I volunteer to finish the work :)
>
> The 2PC patch is really simple, and fixes a data loss issue. The second
> patch has been looked up by Heikki, Magnus and me at least once by each,
> and there is visibly an agreement on having it. Having reviews after
> a new patch version is sent, by somebody else than the one who sent the
> patches is of course always nice..

If you're comfortable committing it then go for it. It will be good to
have the CF item resolved.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-07-06 12:09:27 Re: [HACKERS] Crash on promotion when recovery.conf is renamed
Previous Message Dave Cramer 2018-07-06 12:04:34 Re: How can we submit code patches that implement our (pending) patents?