Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN
Date: 2025-04-30 09:15:20
Message-ID: e8c7d857-f719-4398-9f12-849ddc59bf44@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 28.04.25 18:56, Álvaro Herrera wrote:
> On 2025-Apr-23, Nathan Bossart wrote:
>
>> On Mon, Mar 24, 2025 at 11:37:20AM +0100, Álvaro Herrera wrote:
>
>>> I'd add a note about these two things to the open items page, and wait
>>> to see if we get some of these limitations fixed, so that if we don't,
>>> we remember to note this limitation in the documentation.
>>
>> Are we still waiting on something for this, or should we proceed with the
>> documentation changes? It doesn't seem tremendously urgent, but I noticed
>> it's been about a month since the last message on this thread.
>
> I've edited the Open Items page to disclaim my responsibility from this
> item, since this comes from virtual generated columns which is not my
> turf. I think we should just document the current state of affairs; we
> can come back with further code improvements during the next cycle.

Here is a proposed patch that includes some text about virtual generated
columns and also fixes up a small mistake in the previous patch
(confused identity and generated columns) and improves the wording and
formatting a bit more.

Attachment Content-Type Size
0001-doc-Improve-explanations-when-a-table-rewrite-is-nee.patch text/plain 2.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou (Fujitsu) 2025-04-30 09:37:49 RE: Fix slot synchronization with two_phase decoding enabled
Previous Message Arseniy Mukhin 2025-04-30 08:40:26 GIN tries to form a tuple with a partial compressedList during insertion