Re: jacana vs -Wimplicit-fallthrough

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: jacana vs -Wimplicit-fallthrough
Date: 2020-06-13 20:16:51
Message-ID: e881c5da-39d6-a952-71b5-208a05771782@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 6/13/20 12:25 PM, Tom Lane wrote:
> I happened to notice today that, while the rest of the buildfarm is free
> of implicit-fallthrough warnings, jacana is emitting a whole boatload of
> them. It looks like it must have a different idea of which spellings of
> the "fall through" comment are allowed. Could you check its documentation
> to see what it claims to allow?
>
>

There doesn't seem to be any docco with it. What's odd is that fairywren
is supposedly using the identical compiler, but it's on msys2 while
jacana is msys1. I can't see why that should make a difference, though.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2020-06-13 20:19:41 Re: hashagg slowdown due to spill changes
Previous Message Jeff Davis 2020-06-13 18:48:09 Re: hashagg slowdown due to spill changes