| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: cleaning up PostgresNode.pm |
| Date: | 2021-06-30 13:30:53 |
| Message-ID: | e7e14376-efa2-1871-910a-5c80523c2ed0@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/30/21 8:30 AM, Alvaro Herrera wrote:
> On 2021-Jun-30, Andrew Dunstan wrote:
>
>> On 6/30/21 12:35 AM, Michael Paquier wrote:
>>> On Mon, Jun 28, 2021 at 01:02:37PM -0400, Andrew Dunstan wrote:
>>> skip_equals is not used. The only caller of adjust_conf is
>>> PostgresNode itself.
>> Well, nothing is using it right now :-) It's intended to be available to
>> subclasses.
>>
>> My current subclass code doesn't actually use skip_equals either, but
>> earlier revisions did. Think of modifying pg_hba.conf.
> I thought it was about recovery.conf ...
Yes, that too.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2021-06-30 13:31:03 | Commit fest manager |
| Previous Message | Tom Lane | 2021-06-30 13:28:17 | Re: Remove redundant initializations |