Re: Improved tab completion for PostgreSQL parameters in enums

From: bt21masumurak <bt21masumurak(at)oss(dot)nttdata(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improved tab completion for PostgreSQL parameters in enums
Date: 2021-10-13 18:08:13
Message-ID: e74c67183846d05064f634eec94f77e4@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you for comments.

> I do not think this is an improvement. It will result in omitting
> quotes in some cases where they're not optional. Try it with a
> value such as "all", for example.

> This would break the completion of enum entries that require quotes to
> work properly for some of their values, like
> default_transaction_isolation.

I understand these comments, and the proposal was withdrawn.

Regards,
Kosei Masumura

2021-10-06 23:34 に Tom Lane さんは書きました:
> bt21masumurak <bt21masumurak(at)oss(dot)nttdata(dot)com> writes:
>> If you do tab completion in a situation like A, you will see ["on"]
>> instead of [on].
>
>> A : "ALTER SYSTEM SET wal_compression TO "
>
>> I made a patch for this problem.
>
> I do not think this is an improvement. It will result in omitting
> quotes in some cases where they're not optional. Try it with a
> value such as "all", for example.
>
> regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-10-13 18:31:29 Re: prevent immature WAL streaming
Previous Message Andres Freund 2021-10-13 18:03:39 Re: prevent immature WAL streaming