Re: Clean up code comments for pg_wchar_tbl

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Greg Burd <greg(at)burd(dot)me>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Clean up code comments for pg_wchar_tbl
Date: 2026-10-27 19:24:33
Message-ID: e72a3e48-737e-4b34-9617-12a6dacbd195@proxel.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/27/26 6:18 PM, Greg Burd wrote:
> nit:
>
> s/These functions generally assume that their input is validly formed/These functions generally assume that their input is well formed and valid/

I have not read the rest of the patch yet but as a non-native speaker
the original wording is more clear and your suggested change makes it
seem like "well-formed" and "valid" might be two separate properties.

I think any of the original, "validly formed", or "valid" or
"well-formed" would work.

--
Andreas Karlsson
Percona

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2026-10-27 19:25:00 Re: Clean up code comments for pg_wchar_tbl
Previous Message Matheus Alcantara 2026-10-27 19:16:59 Re: [PATCH] GROUP BY ALL: the regroupening