Re: pgsql: Make WAL segment size configurable at initdb time.

From: David Steele <david(at)pgmasters(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make WAL segment size configurable at initdb time.
Date: 2018-09-21 11:44:06
Message-ID: e6d444e7-b203-52a0-a73c-f30ca94798ee@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 9/21/18 12:53 AM, Michael Paquier wrote:
> On Thu, Sep 20, 2018 at 06:23:54PM -0700, Andres Freund wrote:
>> 16*M*B, right? If so, that's normal - pg_settings just reports the
>> values in the underlying unit - which is XLOG_BLCKSZ, compile-time
>> defaulting to 8KB. 8192 * 2048 = 16MB. That's the same in various other
>> settings.
>
> Would it bring less confusion if we append something like "When querying
> pg_settings"? I can see David's point the current phrasing is
> confusing: we don't know if this comes from pg_settings or from SHOW.
> It obviously refers to the former, but one can understand that it refers
> to the latter.
>
> A second parameter in config.sgml where this formulation is used is
> segment_size.

That's why I used a default of 16MB instead of the byte value, because
segment_size used 1GB instead of the byte value.

--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2018-09-21 12:52:45 pgsql: Use size_t consistently in dsa.{ch}.
Previous Message Michael Paquier 2018-09-21 06:12:48 pgsql: Document lock taken on referenced table when adding a foreign ke

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2018-09-21 11:55:50 Re: Problem while setting the fpw with SIGHUP
Previous Message Alexander Kukushkin 2018-09-21 11:43:28 Re: Connection slots reserved for replication