Re: Failed to delete old ReorderBuffer spilled files

From: atorikoshi <torikoshi_atsushi_z2(at)lab(dot)ntt(dot)co(dot)jp>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Failed to delete old ReorderBuffer spilled files
Date: 2017-11-24 04:38:15
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2017/11/24 10:57, Craig Ringer wrote:
> On 24 November 2017 at 09:20, atorikoshi
>> wrote:
>> Thanks for letting me know.
>> I think I only tested running "make check" at top directory, sorry
>> for my insufficient test.
>> The test failure happened at the beginning of replication(creating
>> slot), so there are no changes yet and getting the tail of changes
>> failed.
>> Because the bug we are fixing only happens after creating files,
>> I've added "txn->serialized" to the if statement condition.
> Thanks.
> Re-reading the patch I see
> * The final_lsn of which transaction that hasn't produced an abort
> * record is invalid.
> which I find very hard to parse. I suggest:
> We set final_lsn when we decode the commit or abort record for a
> transaction,
> but transactions implicitly aborted by a crash never write such a
> then continue from there with the same text as in the patch.
> Otherwise I'm happy. It passes make check, test decoding and the recovery
> TAP tests too.

Thanks for your kind suggestion and running test.
I've added your comment at the beginning.

Atsushi Torikoshi
NTT Open Source Software Center

Attachment Content-Type Size
set_final_lsn_4.patch text/plain 1.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-11-24 04:52:44 Re: [HACKERS] HASH_CHUNK_SIZE vs malloc rounding
Previous Message Haribabu Kommi 2017-11-24 04:06:13 Re: [HACKERS] SERIALIZABLE with parallel query