Re: Remove unnecessary secondary index terms for replication settings

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Robert Treat <rob(at)xzilla(dot)net>, euler(at)eulerto(dot)com
Cc: pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Remove unnecessary secondary index terms for replication settings
Date: 2025-04-25 06:02:09
Message-ID: e62e9e3a-4ec4-4297-a39c-3ca2ad72789b@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On 2025/04/24 23:30, Robert Treat wrote:
> On Wed, Apr 23, 2025 at 2:54 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>
>> Hi,
>>
>> In config.sgml, the entries for max_replication_slots and
>> max_active_replication_origins include secondary index terms:
>>
>> <primary><varname>max_replication_slots</varname> configuration parameter</primary>
>> <secondary>in a sending server</secondary>
>>
>> <primary><varname>max_active_replication_origins</varname> configuration parameter</primary>
>> <secondary>in a subscriber</secondary>
>>
>> These secondary terms don't seem necessary anymore, since each parameter
>> now has only one index entry. Removing them would simplify the documentation.
>>
>> Originally, the secondary entries made sense because
>> max_active_replication_origins was part of max_replication_slots,
>> so both needed separate index entries. But commit 04ff636cbce
>> split them into distinct parameters.
>>
>> Patch attached.
>>
>
> Make sense, +1 from me.

Thanks both for the review! I've pushed the patch.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message PG Doc comments form 2025-04-25 07:21:22 Data visibility for returning statement
Previous Message Laurenz Albe 2025-04-24 20:04:57 Re: Documentation correction suggestion for primary key hashing on partitioned tables