Re: Adding REPACK [concurrently]

From: Alexander Lakhin <exclusion(at)gmail(dot)com>
To: Antonin Houska <ah(at)cybertec(dot)at>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net>
Subject: Re: Adding REPACK [concurrently]
Date: 2026-04-19 11:00:01
Message-ID: e60318b8-be75-4bfd-82f0-0829f51fa839@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello Antonin and Alvaro,

I've noticed a wrong reference coined in commit 28d534e2a:
A comment in repack_worker.c says:
    /*
     * Override the default bgworker_die() with die() so we can use
     * CHECK_FOR_INTERRUPTS().
     */
    pqsignal(SIGTERM, die);
    BackgroundWorkerUnblockSignals();

but bgworker_die() doesn't exist since d62dca3b2 (2026-02-18).
Maybe this is not needed anymore?

Best regards,
Alexander

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Dean Rasheed 2026-04-19 10:42:28 Re: [BUG]: WHERE CURRENT OF cursor fail on tables that have virtual generated columns