Re: [PATCH] pg_input_is_valid() reuses the first type name inside a PL/pgSQL loop

On 11/12/26 02:37, Chao Li wrote:
> I'm afraid we don't have a reliable way to determine if the resolved type has changed in pg_input_is_valid_common() without either resolving the type OID. This means the patch only partially addresses the caching problem. Given that, I'd wait and see if the committers have any concerns about this partial fix.
>
> It feels to me that, without some refactoring, the current caching mechanism cannot reliably handle all these cases.

I am not a fan of the caching mechanism and I wonder why the
pg_input_is_valid() should even try to optimize this in the first place.
As an end user of PostgreSQL I would not expect any caching of the
lookup from type name to oid. If this function had been added now I
personally would have preferred the signature to be:

pg_input_is_valid(text, regtype)

Do we have similar optimizations for other functions which take a type name?

--
Andreas Karlsson
Percona