Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <dgrowleyml(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Subject: Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local
Date: 2022-11-01 21:00:27
Message-ID: e5e13d55-8c8b-30a6-0b13-0304a3e562dd@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01.11.22 19:01, Andres Freund wrote:
> I don't know how much longer we can rely on headers being
> -Wdeclaration-after-statement clean, my impression is that people don't have a
> lot of patience for C89isms anymore.

> I wonder if we should try to use -isystem for a bunch of external
> dependencies. That way we can keep the more aggressive warnings with a lower
> likelihood of conflicting with stuff outside of our control.

Python has the same issues. There are a few other Python-embedding
projects that use -Wdeclaration-after-statement and complain if the
Python headers violate it. But it's getting tedious. -isystem would be
a better solution.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2022-11-01 21:15:27 Re: Pluggable toaster
Previous Message Peter Eisentraut 2022-11-01 20:47:51 Re: psql: Add command to use extended query protocol