| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Fix inconsistencies for v12 (pass 2) |
| Date: | 2019-06-12 14:34:06 |
| Message-ID: | e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Amit,
Can you also review the following fixes?:
2.1. bt_binsrch_insert -> _bt_binsrch_insert (an internal inconsistency)
2.2. EWOULDBOCK -> EWOULDBLOCK (a typo)
2.3. FORGET_RELATION_FSYNC & FORGET_DATABASE_FSYNC ->
SYNC_FORGET_REQUEST (orphaned after 3eb77eba)
2.4. GetNewObjectIdWithIndex -> GetNewOidWithIndex (an internal
inconsistency)
2.5. get_opclass_family_and_input_type ->
get_opclass_opfamily_and_input_type (an internal inconsistency)
2.6. HAVE_BUILTIN_CLZ -> HAVE__BUILTIN_CLZ (missing underscore)
2.7. HAVE_BUILTIN_CTZ -> HAVE__BUILTIN_CTZ (missing underscore)
2.8. MultiInsertInfoNextFreeSlot -> CopyMultiInsertInfoNextFreeSlot (an
internal inconsistency)
2.9. targetIsArray -> targetIsSubscripting (an internal inconsistency)
2.10. tss_htup -> remove (orphaned after 2e3da03e)
I can't see another inconsistencies for v12 for now, but there are some
that appeared before.
If this work can be performed more effectively or should be
postponed/canceled, please let me know.
Best regards,
Alexander
| Attachment | Content-Type | Size |
|---|---|---|
| bt_binsrch_insert.patch | text/x-patch | 572 bytes |
| EWOULDBOCK.patch | text/x-patch | 545 bytes |
| FORGET_RELATION_FSYNC.patch | text/x-patch | 977 bytes |
| get_opclass_family_and_input_type.patch | text/x-patch | 475 bytes |
| GetNewObjectIdWithIndex.patch | text/x-patch | 716 bytes |
| HAVE_BUILTIN_CLZ.patch | text/x-patch | 571 bytes |
| HAVE_BUILTIN_CTZ.patch | text/x-patch | 613 bytes |
| MultiInsertInfoNextFreeSlot.patch | text/x-patch | 541 bytes |
| targetIsArray.patch | text/x-patch | 583 bytes |
| tss_htup.patch | text/x-patch | 372 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2019-06-12 14:35:48 | Re: Binary support for pgoutput plugin |
| Previous Message | Tom Lane | 2019-06-12 13:54:28 | Re: catalog files simplification |