From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Out of date comment in predicate.c |
Date: | 2017-08-23 18:23:55 |
Message-ID: | e58a6e4f-d5c8-cceb-1594-c08d50877c09@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 7/6/17 21:06, Thomas Munro wrote:
> On Sat, Jul 1, 2017 at 6:38 AM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> On 6/27/17 01:21, Thomas Munro wrote:
>>> Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f got rid of
>>> FirstPredicateLockMgrLock, but it's still referred to in a comment in
>>> predicate.c where the locking protocol is documented. I think it's
>>> probably best to use the name of the macro that's usually used to
>>> access the lock array in the code. Please see attached.
>>
>> Does this apply equally to PredicateLockHashPartitionLock() and
>> PredicateLockHashPartitionLockByIndex()? Should the comment mention or
>> imply both?
>
> Yeah, I guess so. How about listing the hashcode variant, as it's the
> more commonly used and important for a reader to understand of the
> two, but mentioning the ByIndex variant in a bullet point below? Like
> this.
Committed and backpatched to 9.4.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-08-23 19:13:30 | Re: POC: Sharing record typmods between backends |
Previous Message | Josh Berkus | 2017-08-23 18:11:29 | Re: Quorum commit for multiple synchronous replication. |