| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Support ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION ... syntax |
| Date: | 2021-04-06 09:56:32 |
| Message-ID: | e586b453-df51-a333-11ec-df8632ea07e6@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06.04.21 07:24, Japin Li wrote:
>>> I think this patch is about ready to commit, but please provide a final
>>> version in good time.
>> I took the liberty to address all the review comments and provide a v9
>> patch on top of Japin's v8 patch-set.
>>
>>> (Also, please combine your patches into a single patch.)
>> Done.
>>
>> Attaching v9 patch, please review it.
>>
> Sorry for the late reply! Thanks for your updating the new patch, and it looks
> good to me.
Committed.
Note that you can use syntax like "ADD|DROP|SET" in the tab completion
code. I have simplified some of your code like that.
I also deduplicated the documentation additions a bit.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2021-04-06 10:25:16 | Re: Asynchronous Append on postgres_fdw nodes. |
| Previous Message | Bharath Rupireddy | 2021-04-06 09:48:57 | Re: Allow batched insert during cross-partition updates |