| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com>, Maksim Milyutin <m(dot)milyutin(at)postgrespro(dot)ru> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Partitioned tables and relfilenode |
| Date: | 2017-03-24 00:54:22 |
| Message-ID: | e57c3a1d-f0c6-fc95-f405-0a109fecf214@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/03/23 23:47, Amit Langote wrote:
> On Thu, Mar 23, 2017 at 11:27 PM, Maksim Milyutin
> <m(dot)milyutin(at)postgrespro(dot)ru> wrote:
>> Hi!
>>
>> I have noticed that there is scheduled unlinking of nonexistent physical
>> storage under partitioned table when we execute DROP TABLE statement on this
>> partitioned table. Though this action doesn't generate any error under
>> typical behavior of postgres because the error of storage's lack is caught
>> through if-statement [1] I think it is not safe.
>>
>> My patch fixes this issue.
>>
>> 1. src/backend/storage/smgr/md.c:1385
>
> Good catch, will incorporate that in the main patch.
And here is the updated patch.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Do-not-allocate-storage-for-partitioned-tables.patch | text/x-diff | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-03-24 01:00:19 | Re: WIP: Faster Expression Processing v4 |
| Previous Message | Andres Freund | 2017-03-24 00:47:34 | Re: WIP: Faster Expression Processing v4 |