From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Common function for percent placeholder replacement |
Date: | 2022-12-19 08:13:09 |
Message-ID: | e541f0be-e08d-e43d-0fa6-c79324e01833@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 14.12.22 17:09, Robert Haas wrote:
> Well, OK, I'll tentatively cast a vote in favor of adopting
> basebackup_to_shell's approach elsewhere. Or to put that in plain
> English: I think that if the input appears to be malformed, it's
> better to throw an error than to guess what the user meant. In the
> case of basebackup_to_shell there are potentially security
> ramifications to the setting involved so it seemed like a bad idea to
> take a laissez faire approach. But also, just in general, if somebody
> supplies an ssl_passphrase_command or archive_command with %<something
> unexpected>, I don't really see why we should treat that differently
> than trying to start the server with work_mem=banana.
I agree. Here is an updated patch with the error checking included.
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Common-function-for-percent-placeholder-replaceme.patch | text/plain | 16.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2022-12-19 08:13:44 | Re: Common function for percent placeholder replacement |
Previous Message | Andres Freund | 2022-12-19 08:12:41 | Re: appendBinaryStringInfo stuff |