Re: Do we really want to migrate plproxy and citext intoPG core distribution?

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
Cc: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, "Asko Oja" <ascoja(at)gmail(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Hannu Krosing" <hannu(at)krosing(dot)net>, "Simon Riggs" <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Do we really want to migrate plproxy and citext intoPG core distribution?
Date: 2008-07-28 12:41:39
Message-ID: e51f66da0807280541i43552887p34c2f4ff6b2a5d69@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/25/08, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> wrote:
> I tackled with hope temporarily. It seems that some adjustment is still
> required.
> http://winpg.jp/~saito/pg_work/plproxy/
> However, windows user desires to use. Of course, it is also me.
> Regards,
> Hiroshi Saito

Thanks, I applied the patch to CVS, with minor changes:
- Use HAVE_SYS_SELECT_H instead of WIN32 for <sys/select.h>
- Do SHLIB_LINK += instead of separate var.

Could you please test the attached patch or CVS HEAD,
whether everything works fine now?

Btw, do not worry about regtest failure in plproxy_many,
this is due to differences in system random() function.
The test should rewritten, although I have not yet decided how...

--
marko

Attachment Content-Type Size
win32.diff text/x-patch 2.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Kreen 2008-07-28 13:03:52 Re: Do we really want to migrate plproxy and citext intoPG core distribution?
Previous Message Dave Cramer 2008-07-28 11:53:21 Re: Protocol 3, Execute, maxrows to return, impact?