| From: | "Marko Kreen" <markokr(at)gmail(dot)com> |
|---|---|
| To: | "Neil Conway" <neilc(at)samurai(dot)com> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Florian Pflug" <fgp(dot)phlo(dot)org(at)gmail(dot)com>, "Mark Kirkwood" <markir(at)paradise(dot)net(dot)nz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: RESET command seems pretty disjointed now |
| Date: | 2007-04-24 15:04:19 |
| Message-ID: | e51f66da0704240804q59bc280dy4bb129d2eac407fa@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/23/07, Neil Conway <neilc(at)samurai(dot)com> wrote:
> On Tue, 2007-04-17 at 16:34 +0300, Marko Kreen wrote:
> > Attached patch does following conversions:
>
> ISTM it would be cleaner to use an enum to identify the different
> variants of the DISCARD command, rather than a character string.
>
> Is guc.c still the logical place for the implementation of DISCARD?
> Something under backend/commands might be better, although I don't see a
> real obvious place for it.
>
> The psql tab completion code requires updating for the new DISCARD
> command.
Attached patch addresses all 3 comments. As it will be
top-level command, I put code into commands/discard.c
--
marko
| Attachment | Content-Type | Size |
|---|---|---|
| discard_v2.diff.gz | application/x-gzip | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-04-24 15:06:52 | Re: BUG #3245: PANIC: failed to re-find shared loc k o b j ect |
| Previous Message | Bruce Momjian | 2007-04-24 15:02:32 | Re: tsearch2 in 8.3 |