Re: [PATCHES] vcbuild optional packages

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Magnus Hagander" <magnus(at)hagander(dot)net>
Cc: PGSQL-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] vcbuild optional packages
Date: 2007-01-14 16:19:50
Message-ID: e51f66da0701140819qa361c42x948e254a84a4ac98@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On 1/14/07, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Is there any reason why the check is "backwards" in pgcrypto compared to
> the rest of the system? All the other places check for HAVE_ZLIB from
> what I can tell.

Eh, just an oversight from my part. I was so focused on Makefile
hacking so I forgot to check if there is already a define
somewhere. And its reverse to have less clutter in command-line
in default case.

Attached patch replaces unnecessary DISABLE_ZLIB define in
pgcrypto with HAVE_LIBZ from core. Result is bit simpler
Makefile which is only good.

--
marko

Attachment Content-Type Size
pgcrypto-simpler-zlib.diff application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Darcy Buskermolen 2007-01-14 16:27:15 Re: Autovacuum improvements
Previous Message Gurjeet Singh 2007-01-14 16:18:15 Re: [PATCHES] [HACKERS] [Fwd: Index Advisor]

Browse pgsql-patches by date

  From Date Subject
Next Message Darcy Buskermolen 2007-01-14 16:27:15 Re: Autovacuum improvements
Previous Message Gurjeet Singh 2007-01-14 16:18:15 Re: [PATCHES] [HACKERS] [Fwd: Index Advisor]