Re: Built-in connection pooler

From: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: David Steele <david(at)pgmasters(dot)net>, "ideriha(dot)takeshi(at)fujitsu(dot)com" <ideriha(dot)takeshi(at)fujitsu(dot)com>, Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Ryan Lambert <ryan(at)rustprooflabs(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Dimitri Fontaine <dim(at)tapoueh(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: Built-in connection pooler
Date: 2020-07-02 15:38:02
Message-ID: e42c8d25-9a1c-a835-c422-0dc56e5775a6@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02.07.2020 17:44, Daniel Gustafsson wrote:
>> On 2 Jul 2020, at 13:33, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru> wrote:
>> On 01.07.2020 12:30, Daniel Gustafsson wrote:
>>>> On 24 Mar 2020, at 17:24, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru> wrote:
>>>> Rebased version of the patch is attached.
>>> And this patch also fails to apply now, can you please submit a new version?
>>> Marking the entry as Waiting on Author in the meantime.
>>>
>>> cheers ./daniel
>> Rebased version of the patch is attached.
> Both Travis and Appveyor fails to compile this version:
>
> proxy.c: In function ‘client_connect’:
> proxy.c:302:6: error: too few arguments to function ‘ParseStartupPacket’
> if (ParseStartupPacket(chan->client_port, chan->proxy->parse_ctx, startup_packet+4, startup_packet_size-4, false) != STATUS_OK) /* skip packet size */
> ^
> In file included from proxy.c:8:0:
> ../../../src/include/postmaster/postmaster.h:71:12: note: declared here
> extern int ParseStartupPacket(struct Port* port, MemoryContext memctx, void* pkg_body, int pkg_size, bool ssl_done, bool gss_done);
> ^
> <builtin>: recipe for target 'proxy.o' failed
> make[3]: *** [proxy.o] Error 1
>
> cheers ./daniel

Sorry, correct patch is attached.

Attachment Content-Type Size
builtin_connection_proxy-29.patch text/x-patch 136.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Artur Zakirov 2020-07-02 15:38:40 Re: [PATCH] fix GIN index search sometimes losing results
Previous Message Daniel Gustafsson 2020-07-02 15:27:52 Re: proposal: unescape_text function