|From:||Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>|
|To:||Robert Haas <robertmhaas(at)gmail(dot)com>|
|Cc:||Pg Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: foreign partition DDL regression tests|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2017/03/09 1:28, Robert Haas wrote:
> On Tue, Feb 21, 2017 at 8:40 PM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Ashutosh Bapat pointed out  that regression tests are missing for the
>> foreign partition DDL commands. Attached patch takes care of that.
> I didn't do anything about Ashutosh's comment that we could use ALTER
> FOREIGN TABLE rather than ALTER TABLE someplace; that didn't seem
Attached is a patch to fix that, just in case.
> Also, the names of the objects in this test are kinda generic (pt2 et.
> al.) but they match the existing names in the same file (pt1, foo).
> If we're going to start differentiating those a little better, we
> should probably change them all, and as a separate commit.
|Next Message||Robert Haas||2017-03-09 01:09:08||Re: [GSoC] Personal presentation and request for clarification|
|Previous Message||Michael Paquier||2017-03-09 00:34:13||Re: Need a builtin way to run all tests faster manner|