| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgres_fdw hint messages |
| Date: | 2022-09-16 13:54:53 |
| Message-ID: | e3ffb099-6ed8-32b7-21d0-bc950e74b3da@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13.09.22 21:02, Nathan Bossart wrote:
> On Tue, Sep 13, 2022 at 08:32:43AM +0200, Peter Eisentraut wrote:
>> I notice that for column misspellings, the hint is phrased "Perhaps you
>> meant X." whereas here we have "Did you mean X?". Let's make that uniform.
>
> Good point. I attached a new version of the patch that uses the column
> phrasing. I wasn't sure whether "reference" was the right word to use in
> this context, but I used it for now for consistency with the column hints.
> I think "specify" or "use" would work as well.
I don't think we need a verb there at all. I committed it without a verb.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maxim Orlov | 2022-09-16 13:59:04 | Re: Add 64-bit XIDs into PostgreSQL 15 |
| Previous Message | osumi.takamichi@fujitsu.com | 2022-09-16 13:51:07 | RE: Allow logical replication to copy tables in binary format |