| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make all Perl warnings fatal |
| Date: | 2023-12-22 21:33:18 |
| Message-ID: | e3f4bf1b-63d3-408a-b07e-d35a0fdf1b98@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12.09.23 07:42, Peter Eisentraut wrote:
> On 10.08.23 07:58, Peter Eisentraut wrote:
>> There are also a couple of issues in the MSVC legacy build system that
>> would need to be tightened up in order to survive with fatal Perl
>> warnings. Obviously, there is a question whether it's worth spending
>> any time on that anymore.
>
> It looks like there are no principled objections to the overall idea
> here, but given this dependency on the MSVC build system removal, I'm
> going to set this patch to Returned with feedback for now.
Now that that is done, here is an updated patch for this.
I found one more bug in the Perl code because of this, a fix for which
is included here.
With this fix, this passes all the CI tests on all platforms.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-warning-in-Perl-test-code.patch | text/plain | 1.3 KB |
| v3-0002-Make-all-Perl-warnings-fatal.patch | text/plain | 130.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2023-12-22 22:04:12 | Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica. |
| Previous Message | David Christensen | 2023-12-22 21:24:50 | Re: [PATCHES] Post-special page storage TDE support |