Re: ICU for global collation

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Daniel Verite <daniel(at)manitou-mail(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com>
Subject: Re: ICU for global collation
Date: 2022-01-21 09:44:24
Message-ID: e381e36c-c7a2-2ec0-dbb4-da1dab3f0941@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 18.01.22 13:54, Peter Eisentraut wrote:
> On 18.01.22 05:02, Julien Rouhaud wrote:
>>> If this is applied, then in my estimation all these hunks will
>>> completely
>>> disappear from the global ICU patch.  So this would be a significant
>>> win.
>> Agreed, the patch will be quite smaller and also easier to review.
>> Are you
>> planning to apply it on its own or add it to the default ICU patchset?
>
> My plan is to apply this patch in the next few days.

This patch has been committed.

Here is a second preparation patch: Change collate and ctype fields to
type text.

I think this is useful by itself because it allows longer locale names.
ICU locale names with several options appended can be longer than 63
bytes. This case is probably broken right now. Also, it saves space in
the typical case, since most locale names are not anywhere near 63 bytes.

Attachment Content-Type Size
0001-Change-collate-and-ctype-fields-to-type-text.patch text/plain 17.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wangw.fnst@fujitsu.com 2022-01-21 09:51:27 RE: Logical replication timeout problem
Previous Message houzj.fnst@fujitsu.com 2022-01-21 09:42:22 RE: row filtering for logical replication