Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jürgen Strobel <juergen+postgresql(at)strobel(dot)info>
Subject: Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation
Date: 2018-12-14 04:22:26
Message-ID: e35f99f6-3455-7cbe-7a2f-34a294c50542@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2018/11/09 14:04, Amit Langote wrote:
> On 2018/11/09 4:39, Alvaro Herrera wrote:
>> I included the test case for collations to the three branches, but no
>> code changes. We can patch master for the handling of collations per
>> your patch,
>
> Okay, but should we back-patch it by adding WARNING to back-branches as
> you suggest?

I was looking at the pending patches that I'd sent and noticed this one to
throw an error when a partition specifies a collation for a column that
doesn't match the parent's. Do we want to apply the attached rebased
patch to HEAD and leave the back-branches (10 and 11) alone?

Thanks,
Amit

Attachment Content-Type Size
0001-Disallow-creating-partitions-with-mismatching-collat.patch text/plain 2.6 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Amul Sul 2018-12-14 08:08:45 Re: ALTER INDEX ... ALTER COLUMN not present in dump
Previous Message Amit Langote 2018-12-14 02:19:16 Re: Errors creating partitioned tables from existing using (LIKE <table>) after renaming table constraints

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2018-12-14 04:55:39 Re: tab-completion debug print
Previous Message Tom Lane 2018-12-14 04:10:25 Re: valgrind issues on Fedora 28