[PATCH] Backport perl tests for pg_upgrade from 322becb60

From: "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: [PATCH] Backport perl tests for pg_upgrade from 322becb60
Date: 2022-07-31 22:02:21
Message-ID: e2b1f3a0-4fda-ba72-5535-2d0395b9e68f@inbox.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


In previous discussion

On 05.07.2022 22:08, Justin Pryzby wrote:
> I'm not
> sure if anyone is interested in patching test.sh in backbranches. I'm not
> sure, but there may be more interest to backpatch the conversion to TAP
> (322becb60).
As far as i understand from this thread: https://www.postgresql.org/message-id/flat/Yox1ME99GhAemMq1%40paquier.xyz,
the aim of the perl version for the pg_upgrade tests is to achieve equality of dumps for most cross-versions cases.
If so this is the significant improvement as previously in test.sh resulted dumps retained unequal and the user
was asked to eyeball them manually during cross upgrades between different major versions.
So, the backport of the perl tests also seems preferable to me.

In the attached patch has a backport to REL_13_STABLE.
It has been tested from 9.2+ and give zero dumps diff from 10+.
Also i've backported b34ca595, ba15f161, 95c3a195,
4c4eaf3d and b3983888 to reduce changes in the 002_pg_upgrade.pl and b33259e2 to fix an error when upgrading from 9.6.
Dumps filtering and some other changes were backported from thread
https://www.postgresql.org/message-id/flat/Yox1ME99GhAemMq1%40paquier.xyz too.
Would be very grateful for comments and suggestions before trying to do this for other versions.

I have a some question concerning patch tester. As Justin said it fails on non-master patches
> since it tries to apply all the *.patch files to the master branch, one after
> another. For branches other than master, I suggest to name the patches *.txt
> or similar.
So, i made a .txt extension for patch, but i would really like to set a patch tester on it.
Is there any way to do this?

With best regards,
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
v1-0001-Backport-perl-tests-for-pg_upgrade-to-v13.txt text/plain 52.4 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Anton A. Melnikov 2022-07-31 22:04:39 Re: [PATCH] Fix pg_upgrade test from v10
Previous Message Stephen Frost 2022-07-31 21:19:34 Re: pg_auth_members.grantor is bunk