| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Covering GiST indexes |
| Date: | 2019-01-29 17:00:29 |
| Message-ID: | e21a2957-2563-77b8-c332-619b32b4b65b@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for the new version of the patch. Based on my knowledge of PG
this is starting to look good, and I have only three small comments below.
I am not 100% a fan of truncTupdesc, but as long as it is well commented
I think that it is fine.
= Review
* I think it is worth writing a short comment when you create
truncTupdesc about why this is done.
* Very minor thing: the diff below is pointless churn on a line not
touched by the patch.
- values, isnull, true /* size is currently bogus
*/ );
+ values, isnull, true /* size is currently bogus
*/);
* Another very minor thing: The diff below from gistFormTuple() should
probably be consistent about brackets.
+ if (isnull[i])
+ compatt[i] = (Datum) 0;
+ else
+ {
+ compatt[i] = attdata[i];
+ }
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2019-01-29 17:02:47 | Re: Covering GiST indexes |
| Previous Message | Robert Haas | 2019-01-29 16:52:25 | Re: ATTACH/DETACH PARTITION CONCURRENTLY |