| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adding support for Default partition in partitioning |
| Date: | 2017-05-17 09:17:43 |
| Message-ID: | e1abea68-ddf1-db12-c61b-39a0efc1dc19@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/05/17 17:58, Ashutosh Bapat wrote:
> On Tue, May 16, 2017 at 9:01 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Tue, May 16, 2017 at 8:57 AM, Jeevan Ladhe
>> <jeevan(dot)ladhe(at)enterprisedb(dot)com> wrote:
>>> I have fixed the crash in attached patch.
>>> Also the patch needed bit of adjustments due to recent commit.
>>> I have re-based the patch on latest commit.
>>
>> + bool has_default; /* Is there a default partition?
>> Currently false
>> + * for a range partitioned table */
>> + int default_index; /* Index of the default list
>> partition. -1 for
>> + * range partitioned tables */
>>
>
> We have has_null and null_index for list partitioning. There
> null_index == -1 = has_null. May be Rahila and/or Jeevan just copied
> that style. Probably we should change that as well?
Probably a good idea.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-05-17 09:25:47 | Re: Increasing parallel workers at runtime |
| Previous Message | Masahiko Sawada | 2017-05-17 09:15:04 | Re: Improvement in log message of logical replication worker |