Re: Non-text mode for pg_dumpall

On 2025-07-29 Tu 4:34 PM, Noah Misch wrote:
> On Tue, Jul 29, 2025 at 04:09:13PM -0400, Andrew Dunstan wrote:
>> here's a reversion patch for master.
>> This reverts parts or all of the following commits:
> I briefly looked through this. The biggest non-reverted part is, I think,
> c1da728 "Move common pg_dump code related to connections to a new file".
> Refraining from a revert of that one is defensible.

Yes, that was deliberate, since we intend to use it in the same way when
we redo this.

>
>> dec6643487b Improve pg_dump/pg_dumpall help synopses and terminology
>> @@ -1276,7 +1276,7 @@ main(int argc, char **argv)
>> static void
>> help(const char *progname)
>> {
>> - printf(_("%s exports a PostgreSQL database as an SQL script or to other formats.\n\n"), progname);
>> + printf(_("%s dumps a database as a text file or to other formats.\n\n"), progname);
>> printf(_("Usage:\n"));
>> printf(_(" %s [OPTION]... [DBNAME]\n"), progname);
> I think commit dec6643487b, which e.g. decided to standardize on the term
> "export" for these programs, was independent of $SUBJECT.

OK, thanks for looking. Will fix.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com