From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: remove ancient pre-dlopen dynloader code |
Date: | 2018-08-31 08:52:18 |
Message-ID: | e11a49cb-570a-60b7-707d-7084c8de0e61@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 16/08/2018 16:10, Andres Freund wrote:
>>> If I had my druthers, we'd just remove all that configure magic for
>>> selecting these files and just use ifdefs. Personally I find it
>>> occasionally that they're linked into place, rather than built under
>>> their original name.
>>
>> Even if we all agreed that was an improvement (which I'm not sure of),
>> it wouldn't fix this problem would it? On affected platforms, the
>> file would still be empty after preprocessing.
>
> Well, that depends on what you put into that file, it seems
> realistically combinable with a bunch of non-conditional code...
How about this: We only have two nonstandard dlopen() implementations
left: Windows and (old) HP-UX. We move those into src/port/dlopen.c and
treat it like a regular libpgport member. That gets rid of all those
duplicative empty per-platform files.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Refactor-dlopen-support.patch | text/plain | 38.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Rafia Sabih | 2018-08-31 08:55:20 | Re: Hint to set owner for tablespace directory |
Previous Message | Masahiko Sawada | 2018-08-31 08:35:54 | Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module |