|From:||Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>|
|To:||Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>|
|Cc:||Andres Freund <andres(at)anarazel(dot)de>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Subject:||Re: WIP Patch: Precalculate stable functions, infrastructure v1|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
> Hi Marina,
> I still don't see anything particularly wrong with your patch. It
> applies, passes all test, it is well test-covered and even documented.
> Also I've run `make installcheck` under Valgrind and didn't find any
> memory-related errors.
Thank you very much as usual!
> Is there anything that you would like to change before we call it more
> or less final?
I would like to add some primitive nodes for precalculation if their
behaviour allows to do it and their arguments/inputs are constant or
precalculated too; and regression tests for it, of course. Also I would
like to add some notes about precalculation of stable functions in
documentation, for example, here  and here .
> Also I would advice to add your branch to our internal buildfarm just
> make sure everything is OK on exotic platforms like Windows ;)
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
|Next Message||Alexander Sosna||2017-05-31 08:50:24||Re: Segmentation fault when creating a BRIN, 10beta1|
|Previous Message||Andres Freund||2017-05-31 07:24:48||Re: logical replication busy-waiting on a lock|