| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>, "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: list of extended statistics on psql |
| Date: | 2021-01-20 22:00:50 |
| Message-ID: | e08cfd09-6803-abd5-2690-0e228c537d37@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/20/21 7:41 AM, Tatsuro Yamada wrote:
> Hi Tomas,
>
> On 2021/01/20 11:35, Tatsuro Yamada wrote:
>>> Apologies for all the extra work - I haven't realized this flaw when
>>> pushing for showing more stuff :-(
>>
>> Don't worry about it. We didn't notice the problem even when viewed by
>> multiple
>> people on -hackers. Let's keep moving forward. :-D
>>
>> I'll send a patch including a regression test on the next patch.
>
>
> I created patches and my test results on PG10, 11, 12, and 14 are fine.
>
> 0001:
> - Fix query to use pg_statistic_ext only
> - Replace statuses "required" and "built" with "defined"
> - Remove the size columns
> - Fix document
> - Add schema name as a filter condition on the query
>
> 0002:
> - Fix all results of \dX
> - Add new testcase by non-superuser
>
> Please find attached files. :-D
Thanks, I've pushed this. I had to tweak the regression tests a bit, for
two reasons:
1) to change user in regression tests, don't use \connect, but SET ROLE
and RESET ROLE
2) roles in regression tests should use names with regress_ prefix
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anastasia Lubennikova | 2021-01-20 22:03:58 | Re: pg_upgrade fails with non-standard ACL |
| Previous Message | James Hilliard | 2021-01-20 21:52:19 | Re: [PATCH 1/1] Fix detection of pwritev support for OSX. |