| From: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | IntArray in c.h |
| Date: | 2009-12-29 09:50:30 |
| Message-ID: | e08cc0400912290150x67586acaq8ddf7e83b1e35ab0@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I found the struct IntArray defined in c.h is actually used only in
execQual.c. ISTM the definition should be at least moved to the right
place.
Attached is a trivial fix. Addition to the explanation above, I
replaced IntArray by simple int array bounded with MAXDIM and remove
local variable lIndex in ExecEvalArrayRef because the usage of the
variable doesn't seem good to me.
Regression passed and various manual tests like "UPDATE t SET
a[1:2][1] = 1" didn't fail.
Regards,
--
Hitoshi Harada
| Attachment | Content-Type | Size |
|---|---|---|
| IntArray.patch | application/octet-stream | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tarun Sharma | 2009-12-29 10:26:45 | Can we hide data from the superadmin |
| Previous Message | Robert Haas | 2009-12-29 08:06:21 | Re: [PATCH] Provide rowcount for utility SELECTs |