Re: Windowing Function Patch Review -> NTH_VALUE

From: "Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com>
To: "David Rowley" <dgrowley(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Windowing Function Patch Review -> NTH_VALUE
Date: 2008-11-12 09:46:31
Message-ID: e08cc0400811120146r3c47b320g8aac5e22c05c8829@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2008/11/12 1:09 Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>:
> So obviously nth_value(expr, 0) causes error and nth_value(expr, 1)
> returns the first row. I will update my patch soon.

Fixed these issues:
- ntile() value check
- nth_value() value check and behavior change

Also, I found a bug that is fixed in this release:

SELECT sum(salary) OVER w1, count(*) OVER w2 FROM empsalary WINDOW w1
AS (ORDER BY salary), w2 AS (ORDER BY salary);

The identical windows named differently were not processed
appropriately. It works now.

Regards,

--
Hitoshi Harada

Attachment Content-Type Size
window_functions.patch.20081112-1.gz application/x-gzip 47.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hitoshi Harada 2008-11-12 09:47:12 Re: Windowing Function Patch Review -> NTH_VALUE
Previous Message Martijn van Oosterhout 2008-11-12 07:18:57 Re: Block-level CRC checks