Re: pgsql: Invalidate RI fast-path metadata on operator family changes

From: Alexander Lakhin <exclusion(at)gmail(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>, Amit Langote <amitlan(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Invalidate RI fast-path metadata on operator family changes
Date: 2026-09-19 18:00:00
Message-ID: e0258f8a-b8f5-411b-963f-5499afe78bf2@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hello Amit,

19.09.2026 12:14, Amit Langote wrote:
>> I noticed a few BF failures, after pushing the above changes:
>>
>> ...
>>
>> I don't see any relation between these failures and my commit. window
>> runs concurrently with foreign_key, but this commit's additions to the
>> latter are self-contained (a private operator family in its own
>> schema), so I don't see why window's plans would be affected.
>>
>> Does anyone see it differently?
> Forgot to add that the code change is isolated too in that it only
> changes what ri_triggers.c does on a pg_amop invalidation during an RI
> fast-path check, not anything the planner consults. It doesn't touch
> pg_constraint or how FKs feed planning, so I don't see a route from
> this commit's changes to these window plans. Any effect would be
> timing at most. I would not claim that I have figured this out.

I've reproduced such failures locally with:
test: test_setup
test: create_index
test: foreign_key window
x100

I think the window failures are caused by these additions:
+create operator family fam using btree;
+create operator class int_ops for type integer using btree family fam as
+  operator 1 <(integer,integer), operator 2 <=(integer,integer),
+  operator 3 =(integer,integer), operator 4 >=(integer,integer),
+  operator 5 >(integer,integer), function 1 btint4cmp(integer,integer);

Best regards,
Alexander

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Richard Guo 2026-09-20 00:43:31 Re: pgsql: Invalidate RI fast-path metadata on operator family changes
Previous Message Andrew Dunstan 2026-09-19 15:02:09 Re: pgsql: Check that oldestXID and oldestMulti are consistent at pg_upgrad