Re: meson: Optionally disable installation of test modules

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: meson: Optionally disable installation of test modules
Date: 2023-02-08 10:30:10
Message-ID: dff4a747-4d3d-99f9-2b78-fa6d7febb6db@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01.02.23 13:41, Nazir Bilal Yavuz wrote:
> On 1/31/23 11:44, Peter Eisentraut wrote:
>> On 30.01.23 18:42, Andres Freund wrote:
>>> Bilal, with a bit of help by me, worked on an alternative approach to
>>> this. It's a lot more verbose in the initial change, but wouldn't
>>> increase the
>>> amount of work/lines for new test modules. The main advantage is that we
>>> wouldn't have disable the modules by default, which I think would be
>>> quite
>>> likely to result in plenty people not running the tests.
>>>
>>> Sending a link instead of attaching, in case you already registered a
>>> cfbot entry:
>>> https://github.com/anarazel/postgres/commit/d1d192a860da39af9aa63d7edf643eed0eeee7c4
>>>
>>> Probably worth adding an install-test-modules target for manual use.
>>
>> Looks like a good idea.  I'm happy to proceed along that line.
>
> I am adding a patch of an alternative approach. Also, I updated the
> commit at the link by adding regress_module, autoinc_regress and
> refint_regress to the test_install_libs.

If you feel that your patch is ready, please add it to the commit fest.
I look forward to reviewing it.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2023-02-08 10:31:30 Re: generic plans and "initial" pruning
Previous Message Fujii Masao 2023-02-08 10:29:40 Re: make_ctags: use -I option to ignore pg_node_attr macro