Re: BUG #18952: pg_restore --help and document have strange description: Dump something

On 2025/06/10 16:35, PG Bug reporting form wrote:
> The following bug has been logged on the website:
>
> Bug reference: 18952
> Logged by: TAKATSUKA Haruka
> Email address: harukat(at)sraoss(dot)co(dot)jp
> PostgreSQL version: 18beta1
> Operating system: any
> Description:
>
> pg_restore --help has strange description like "Dump .....":
> [dbhost]$ LANG=C pg_restore --help
> pg_restore restores PostgreSQL databases from archives created by pg_dump or
> pg_dumpall.
> Usage:
> pg_restore [OPTION]... [FILE]
> (snip)
> --with-data dump the data
> --with-schema dump the schema
> --with-statistics dump the statistics
> Connection options:
> -h, --host=HOSTNAME database server host or socket directory
> (snip)
> https://www.postgresql.org/docs/18/app-pgrestore.html also have the
> following description.
> --with-data
> Dump data. This is the default.
> --with-schema
> Dump schema (data definitions). This is the default.
> --with-statistics
> Dump statistics. This is the default.

Thanks for the report!

Are you suggesting that "dump" in the help message and docs should be "restore"?
If so, does the attached patch address that correctly?

Regards,

--
Fujii Masao
NTT DATA Japan Corporation