| From: | "Jonathan Gonzalez V(dot)" <jonathan(dot)abdiel(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add pg_get_publication_ddl function |
| Date: | 2026-05-17 21:27:15 |
| Message-ID: | defc1876a11710f61228835471c0cdf402167314.camel@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello all!!
I'm attaching the v2 of this patch! There's a lot of changes but I'll
try to mention the biggest ones:
* Adopted the new structure following the previous committed patches of
tablespaces and databases.
* Added the options for pretty and owner, also added the statement that
will alter the publication to have the owner. I didn't know if it was
required since the CREATE PUBLICATION doesn't have a way to add the
OWNER, but since all the other functions were doing the same, I think
it's the way to do it.
* Some improvements on managing the string splits, there's really
useful functions for bitmapsets and lists so I use them to decide if we
were in the first element or not.
* I decided to use the cache instead of opening the relation with a
shared lock, I hope it was the right decision since it didn't make
sense to me to have a lock for a DDL.
* I took all the comments and check the grammar
* Even more tests were added since many corner cases were not detected
in the first version, the regress tests helped a lot on finding corner
cases
* Added the EXCEPT clause that was added after the first version.
Thank you for your reviews!
--
Jonathan Gonzalez V.
EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Introduce-a-new-function-pg_get_publication_ddl-t.patch | text/x-patch | 88.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-05-17 21:45:17 | Re: Fix SPLIT PARTITION bound-overlap bug and other improvements |
| Previous Message | Alvaro Herrera | 2026-05-17 20:46:08 | Re: [PATCH] Fix REPACK decoding worker not cleaned up on FATAL exit |