Re: Fix accidentally cast away qualifiers

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix accidentally cast away qualifiers
Date: 2026-01-26 15:09:00
Message-ID: deb94c8a-673e-4a25-97ca-c0b2cc22effc@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 21.01.26 15:56, Bertrand Drouvot wrote:
> Hi,
>
> On Wed, Jan 21, 2026 at 02:24:58PM +0000, Bertrand Drouvot wrote:
>> Hi,
>>
>> On Wed, Jan 21, 2026 at 12:31:27PM +0100, Peter Eisentraut wrote:
>>> Strange, I don't see that. What compiler is this, and do you use any
>>> special options?
>>
>> It's gcc 14.1.0 with "CFLAGS=-O0 -ggdb3 -fno-omit-frame-pointer -gdwarf-2 -g3
>> -Wdiscarded-qualifiers -Wunused-value -Werror=maybe-uninitialized
>> -Werror=format -Wreturn-type"
>>
>> But I just tested with a simple test case, some compilers and some options and I've
>> always seen the warning (see [1])
>
> FWIW, and so does the CI: https://github.com/bdrouvot/postgres/runs/61028037498

I must have done something wrong on my side. I have committed it with
your corrections.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-01-26 15:23:16 Re: unnecessary executor overheads around seqscans
Previous Message Andres Freund 2026-01-26 15:08:47 Re: pg_stat_io_histogram