From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fixing typos in tests of partition_info.sql |
Date: | 2018-12-17 07:41:01 |
Message-ID: | de95965d-7e1e-ac0b-5cf8-90626a405f35@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2018/12/17 16:38, Michael Paquier wrote:
> On Mon, Dec 17, 2018 at 04:14:07PM +0900, Amit Langote wrote:
>> --- A table not part of a partition tree works is the only member listed.
>> +-- A table not part of a partition tree is the only member listed.
>>
>> How about:
>>
>> -- Table that is not part of any partition tree is the only member listed
>>
>> --- Views and materialized viewS cannot be part of a partition tree.
>> +-- Views and materialized views are not part of a partition tree,
>> +-- causing the functions to return NULL.
>>
>> How about:
>>
>> -- Functions returns NULL for relation types that cannot be part of a
>> -- partition tree; for example, views, materialized views, etc.
>
> Your two suggestions look fine to me, so let's just reuse your wording.
> i would just use the plural for the last comment with "Functions return"
> as pg_partition_tree gets called multiple times, and later on
> pg_partition_root will likely be added.
Okay, let's use "Functions" then, although I wonder if you shouldn't tweak
it later when you commit the pg_partition_root patch?
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | amul sul | 2018-12-17 07:49:00 | Re: ALTER INDEX ... ALTER COLUMN not present in dump |
Previous Message | Michael Paquier | 2018-12-17 07:38:23 | Re: Fixing typos in tests of partition_info.sql |